Skip to content

Upgrade test blueprints to beta #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade test blueprints to beta #119

wants to merge 1 commit into from

Conversation

cironunes
Copy link
Member

No description provided.

@cironunes cironunes changed the title Upgrade test bps beta Upgrade test blueprints to beta Dec 16, 2015
Foxandxss
Foxandxss reviewed Dec 22, 2015
View reviewed changes
addon/ng2/blueprints/component-test/files/src/app/components/__name__/__name__.spec.ts
@@ -18,8 +17,8 @@ describe('<%= classifiedModuleName %> Component', () => {
beforeEachProviders(() => []);


it('should ...', injectAsync([TestComponentBuilder], (tcb:TestComponentBuilder) => {
return tcb.createAsync(<%= classifiedModuleName %>).then((fixture) => {
it('should ...', inject([TestComponentBuilder], (tcb:TestComponentBuilder) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not completely sure about this. Seems like the update to remove this would give false passing tests.

@filipesilva
Copy link
Contributor

@cironunes is this PR up to date?

@cironunes cironunes force-pushed the upgrade-test-bps-beta branch from ab54306 to 4bfad58 Compare January 31, 2016 12:12
@cironunes
Copy link
Member Author

@filipesilva just rebased. Can you merge it in?

@Foxandxss
Copy link
Member

I want to summon @pkozlowski-opensource or @juliemr because we tried to change injectAsync into inject (in ng-bootstrap) but it wasn't a good idea after all. Not sure if that changed lately or if it is better to have injectAsync for the time being.

@filipesilva
Copy link
Contributor

I can't speak much for the inject vs injectAsync myself either.

@Foxandxss
Copy link
Member

More reference here ng-bootstrap/ng-bootstrap#135

@cironunes
Copy link
Member Author

thanks for letting us know @Foxandxss. I'll close this for now, we can revisit this in the future.

@cironunes cironunes closed this Jan 31, 2016
@cironunes cironunes deleted the upgrade-test-bps-beta branch January 31, 2016 14:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cironunes @filipesilva @Foxandxss